merge shouldThrowTheException into shouldThrow

[AndreasVolkmann]

I noticed the shouldThrowTheException() method is kind of obsolete.

We can just make the shouldThrow return an ExceptionResult, which can be evaluated (withMessage) if needed, or disregarded.

Now the shouldThrow() covers both use cases, but is much shorter and easier to read.

Example:
func shouldThrow Exception::class withCause IOException::class

What do you think?

[MarkusAmshove]

Really nice find!

I'm on holiday at the moment and looking at the diff through my mobile phone.
Did you remove the "should throw the exception"? This might break some people's code.

I like the idea to use "should throw" for both cases and would propose to keep both ways (to be backwards compatible). It think it good way would be to mark the old way as deprecated and promote the new way in the documentation (without mentioning the old).

What do you think about doing it this way?

Sent from my Vernee Apollo Lite using FastHub

[AndreasVolkmann]

I was thinking about whether to remove it as well. I find your approach suitable and will update the PR soon. Enjoy your holiday.

[MarkusAmshove]

It took some time but I've now merged it back in and released it within 1.27 ;-) Thank you!