Improve assertSoftly compatibility #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 14, 2021 11:19
Added a common point at which exceptions are thrown, so that (almost) all assertions are now compatible with assertSoftly. Added notes in documentation about assertSoftly compatibility.
|
SonarCloud Quality Gate failed. |
|
Hi, should I modify the PR, or can it be merged in the current state? |
MarkusAmshove
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Almost all assertions should now work well with
assertSoftly.Previously, some assertions would directly throw
AssertionError.failwould also throw, ignoring soft error collection mode.This change exposes
fail(message:String?): Unitin the public API of the libraryThis should resolve all issues with #196.
Checklist
AUTHORSfile, if it wasn't already present.