Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various bug fixes in Equivalency functionality and improvements in the ComparisonFailure message formatting (used by assertSoftly) #186

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

drcolombo
Copy link
Contributor

Various bug fixes and improvements in the ComparisonFailure message formatting.

@sonarcloud
Copy link

sonarcloud bot commented Dec 29, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_275) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 11.
Read more here

@drcolombo drcolombo changed the title Various bug fixes and improvements Various bug fixes in Equivalency functionality and improvements in the ComparisonFailure message formatting (used by assertSoftly) Dec 31, 2020
@MarkusAmshove
Copy link
Owner

I really like the way how the new comparison failures look :-) Let me know when you're ready to merge!

Copy link
Owner

@MarkusAmshove MarkusAmshove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkusAmshove MarkusAmshove merged commit cf6154c into MarkusAmshove:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants