-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#178: added support for assertSoftly #185
Conversation
Thank you for the PR, this looks really useful and I'm willing to merge it! I'm a bit hesitant on the "based on the logic from Kotest" part, do you know which parts/files you've taken from Kotest so we can add the proper attribution in the README? Kotest has the Apache license, so it should be fine to add the proper attribution and use it (I can do it after the merge if I know which files are based or copied from Kotest) :-) |
|
Tomorrow I'll provide additional code changes (didn't notice that kotlin.test.assert* were still used internally in Kluent) and updated documentation. So please, do not merge until further notice 😉 |
… internally implemented within Kluent to support assertSoftly notation; 2. Updated/fixed code and tests for JS and NATIVE; 3. Added documentation (docs/SoftlyAssertions.md) describing the assertSoftly notation.
SonarCloud Quality Gate failed. 0 Bugs 12.8% Coverage The version of Java (1.8.0_275) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 11. |
Added support for assertSoftly notation (#178 ) based on the logic from Kotest