Using Java's printing for logging #95
Conversation
Fixes #52 Added input field types from Python version Some refactoring
|
Some tests seem to be broken (brobably because of changes done. Try to check those and release probably tomorrow. |
| @@ -319,7 +319,7 @@ public String getRemoteCapabilities() { | |||
| // Null returned from jbrowserdriver | |||
| if (getCurrentWebDriver() instanceof RemoteWebDriver | |||
| && ((RemoteWebDriver) getCurrentWebDriver()).getCapabilities() != null) { | |||
| System.out.println(getCurrentWebDriver()); | |||
| logging.info(getCurrentWebDriver().toString()); | |||
There was a problem hiding this comment.
Could you add more information about this log:
logging.info(String.format("Sitting capabilities for current browser - %s", getCurrentWebDriver().toString()));
| @@ -50,6 +50,7 @@ public static WebElement findByHeader(WebDriver webDriver, String tableLocator, | |||
|
|
|||
| public static WebElement findByFooter(WebDriver webDriver, String tableLocator, String content) { | |||
| List<String> locators = parseTableLocator(tableLocator, "footer"); | |||
| System.out.println(Arrays.toString(locators.toArray())); | |||
There was a problem hiding this comment.
System.out.println(String.format("Find by footer locators: %s", locators));
There was a problem hiding this comment.
Does this always output the message to a console? As a library user I don't want to see debug messages unless I'm in a debug mode.
There was a problem hiding this comment.
I agree with you but I think if don’t remove the output, it’s better to make it readable for any users))
There was a problem hiding this comment.
This was just for debugging, used System.out.println to easily spot the ones needed to be removed.
There was a problem hiding this comment.
ok. I think it can be removed from PR)
| if (locator.charAt(locatorParts[0].length()) == "=".charAt(0)) { | ||
| System.out.println("*WARN* '=' is deprecated as locator strategy separator. ':' should be used instead" ); | ||
| } | ||
| if (locator.charAt(locatorParts[0].length()) == "=".charAt(0)) { |
There was a problem hiding this comment.
if (locator.charAt(locatorParts[0].length()) == '=') {
| ,(xpathConstraints.size() > 0 ? " and " : ""), Python.join(" or ", xpathSearchers)); | ||
| String xpath = String.format("//%s[%s%s(%s)]", | ||
| xpathTag, | ||
| (xpathConstraints.size() > 0 ? "("+StringUtils.join(xpathConstraints, " or ")+")" : ""), |
There was a problem hiding this comment.
You can use String.format
That's already done with commit b053abc. It just seemed to use a bit more memory in Maven build, but at least code is simpler. |
Fixes #92