Skip to content

Conversation

@Naragod
Copy link
Contributor

@Naragod Naragod commented Nov 17, 2025

Proposed Changes

Enable downloads in zip format of graded assignments. Unzipped files will be in JSON format.

Screenshots of your changes (if applicable) Screenshot 2025-11-17 at 6 30 11 PM
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality) X
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots) X
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@Naragod Naragod added this to the v2.8.3 milestone Nov 17, 2025
@Naragod Naragod requested a review from donny-wong November 17, 2025 23:31
@Naragod Naragod linked an issue Nov 17, 2025 that may be closed by this pull request
@Naragod Naragod force-pushed the ISSUE-7712_enable_zip_download branch 2 times, most recently from 30077f9 to f22281a Compare November 18, 2025 00:58
@coveralls
Copy link
Collaborator

coveralls commented Nov 18, 2025

Pull Request Test Coverage Report for Build 19640542309

Details

  • 55 of 55 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 91.532%

Totals Coverage Status
Change from base Build 19618586868: 0.009%
Covered Lines: 43533
Relevant Lines: 46748

💛 - Coveralls

@Naragod Naragod force-pushed the ISSUE-7712_enable_zip_download branch from f22281a to 75d0403 Compare November 19, 2025 19:04
@donny-wong
Copy link
Contributor

Thanks @Naragod. Is there a reason why we do not have a zip download for csv format?

Copy link
Contributor

@donny-wong donny-wong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @Naragod! I left a comment. Once that is cleared I will approve this. Thanks.

@Naragod
Copy link
Contributor Author

Naragod commented Nov 21, 2025

Thanks @Naragod. Is there a reason why we do not have a zip download for csv format?

Hey @donny-wong, I picked JSON as the default zipped format of the file stored in the zip archive without a specific reason in mind. We can add the csv file into the zip archive, or change the stored file to csv.

@donny-wong
Copy link
Contributor

Thanks @Naragod. Is there a reason why we do not have a zip download for csv format?

Hey @donny-wong, I picked JSON as the default zipped format of the file stored in the zip archive without a specific reason in mind. We can add the csv file into the zip archive, or change the stored file to csv.

Thanks @Naragod, I'm ok with this. Let's see if David is as well. In the mean time, please update your branch. Thanks.

@Naragod Naragod force-pushed the ISSUE-7712_enable_zip_download branch from 1815d61 to 4c93c42 Compare November 24, 2025 15:55
@david-yz-liu david-yz-liu merged commit 210679b into master Nov 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Download test results in compressed zip format

5 participants