-
Notifications
You must be signed in to change notification settings - Fork 251
ISSUE-7712: Enable zip downloads of graded assignments #7733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
30077f9 to
f22281a
Compare
Pull Request Test Coverage Report for Build 19640542309Details
💛 - Coveralls |
f22281a to
75d0403
Compare
|
Thanks @Naragod. Is there a reason why we do not have a zip download for |
donny-wong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @Naragod! I left a comment. Once that is cleared I will approve this. Thanks.
Hey @donny-wong, I picked JSON as the default zipped format of the file stored in the zip archive without a specific reason in mind. We can add the csv file into the zip archive, or change the stored file to csv. |
Thanks @Naragod, I'm ok with this. Let's see if David is as well. In the mean time, please update your branch. Thanks. |
1815d61 to
4c93c42
Compare
Proposed Changes
Enable downloads in
zipformat of graded assignments. Unzipped files will be inJSONformat.Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)