ISSUE-7687: Remove criteria UPDATE conflicts

[Naragod]

Proposed Changes

This is a 🐛 Bug fix.

We are unable to swap two records within the same transaction. Built in validators run into the issue of constraint infractions. This happens when an attempt is made to swap two values wthin the same transaction. Each record is compared against the database before the second has had a chance to update. More information about this specific issue and how it can be reproduced can be found here.

Implementation

Our issue can be resolved by implementing custom validators, which have access to in memory data and can be used to validate final state changes. By contrast, built-in rails uniqueness validators query the database, their information limited, to pre-updated records.

Screenshots of your changes (if applicable)

Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type	Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)	X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

• I have performed a self-review of my changes.
  • Check that all changed files included in this pull request are intentional changes.
  • Check that all changes are relevant to the purpose of this pull request, as described above.
• I have added tests for my changes, if applicable.
  • This is required for all bug fixes and new features.
• I have updated the project documentation, if applicable.
  • This is required for new features.
• If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

• I have updated the project Changelog (this is required for all changes).
• I have verified that the pre-commit.ci checks have passed.
• I have verified that the CI tests have passed.
• I have reviewed the test coverage changes reported by Coveralls.
• I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

[coveralls]

Pull Request Test Coverage Report for Build 18546551874

Details

• 24 of 24 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.003%) to 91.523%

---

Totals
Change from base Build 18541419932:	0.003%
Covered Lines:	42513
Relevant Lines:	45665

---

💛 - Coveralls

[david-yz-liu]

Nice work @Naragod 👍