-
Notifications
You must be signed in to change notification settings - Fork 251
Fix Rack HTTP status code deprecation warnings #7675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Rack HTTP status code deprecation warnings #7675
Conversation
|
Hi @david-yz-liu , after speaking with @freyazjiner, I believe that both her and I are experience the same issue with the coveralls parallel step of the CI failing. I will try to debug the issue with her tonight and work on my other PR in the meantime. Update: just learned that Freya has asked you about the issue and that I can proceed with a review request, hope it gets resolved soon; I've requested a review! |
david-yz-liu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lxyhan this is good, please just update the Changelog. Make sure to include the PR number in the changelog entry (I forgot to mention this on your previous PR).
Don't worry about the Coveralls failure, I think that's just their server being flaky, and isn't something that's worth looking into.
Pull Request Test Coverage Report for Build 18018678414Details
💛 - Coveralls |
Changelog.md
Outdated
| - Added tests to improve coverage for `AnnotationCategory`'s `self.to_json` method | ||
| - Added tests to the Criteria Controller class to achieve full test coverage | ||
| - Refactored Criterion subclasses to remove redundant code | ||
| - Refactored Criterion subclasses to remove redundant code3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should not have been changed (please look carefully at the diffs on GitHub as part of your self-review before requesting a review)
david-yz-liu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @lxyhan!
Proposed Changes
Fix Rack HTTP status code deprecation warnings by updating deprecated symbols to their modern equivalents:
:payload_too_largewith:content_too_large(HTTP 413):unprocessable_entitywith:unprocessable_content(HTTP 422)Motivation: Rack PR #2137 deprecated these symbols. This change eliminates deprecation warnings when running tests and ensures compatibility with future Rack versions.
Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)