Skip to content

Conversation

@hemmatio
Copy link
Member

@hemmatio hemmatio commented Aug 24, 2025

Proposed Changes

This PR aims to use awalsh128/cache-apt-pkgs-action@latest to cut down on the time spent installing system dependencies. Packages are cached upon first installation (local to a branch, but also falling back to the default branch) and pulled from the cache instead of re-installing.
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

Actions run w/ fresh install
Actions run w/ cached install

Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration) X

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

  • It seems much harder to cache the installation of Playwright's chromium dependencies, as they are abstracted and not explicitly listed (which leads me to believe that they are prone to volatile changes)
  • The term Install and cache system dependencies may not be 100% accurate, since it's technically only caching the first time around. It could be improved, but I'm not sure how much that matters.

@hemmatio hemmatio marked this pull request as ready for review August 24, 2025 07:35
@coveralls
Copy link
Collaborator

coveralls commented Aug 24, 2025

Pull Request Test Coverage Report for Build 17220680562

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.846%

Totals Coverage Status
Change from base Build 17086569490: 0.0%
Covered Lines: 42121
Relevant Lines: 45146

💛 - Coveralls

@hemmatio hemmatio requested a review from david-yz-liu August 24, 2025 20:29
Copy link
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hemmatio, this is great! The name of the action is fine.

Regarding the playwright dependencies, they're located here: https://github.com/microsoft/playwright/blob/main/packages/playwright-core/src/server/registry/nativeDeps.ts.

It would be great if you could add this (fairly long) list to the cached dependencies, and remove the install-deps playwright step below. I suspect this will shave off another minute or so from the build time. You can add a comment linking to the source code in our test_ci.yml file as a reference; looking at the git history, the list is quite stable, so I don't anticipate issues keeping it up to date.

@hemmatio hemmatio requested a review from david-yz-liu August 26, 2025 01:44
Copy link
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hemmatio!

@david-yz-liu david-yz-liu merged commit 3d2b5b1 into MarkUsProject:master Aug 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants