Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
### ✨ New features and improvements

### 🐛 Bug fixes
- Fixed group member filtering in assignment summary table (#7644)

### 🔧 Internal changes
- Updated the assignment summary table to use `@tanstack/react-table` v8 (#7630)
Expand Down
9 changes: 5 additions & 4 deletions app/javascript/Components/assignment_summary_table.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -66,22 +66,23 @@ export class AssignmentSummaryTable extends React.Component {
},
filterFn: (row, columnId, filterValue) => {
if (filterValue) {
filterValue = filterValue.toLowerCase();
// Check group name
if (row.original.group_name.includes(filterValue)) {
if (row.original.group_name.toLowerCase().includes(filterValue)) {
return true;
}

// Check member names
// Check member names (first three values of each "member" array)
const member_matches = row.original.members.some(member =>
member.some(name => name.includes(filterValue))
member.slice(0, 3).some(name => name.toLowerCase().includes(filterValue))
);

if (member_matches) {
return true;
}

// Check grader user names
return row.original.graders.some(grader => grader.includes(filterValue));
return row.original.graders.some(grader => grader.toLowerCase().includes(filterValue));
} else {
return true;
}
Expand Down