Users table refactor #7598
Merged
Users table refactor #7598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Pull Request Test Coverage Report for Build 16477006285Details
💛 - Coveralls |
Collaborator
david-yz-liu
left a comment
david-yz-liu
left a comment
There was a problem hiding this comment.
@chickenwaddle77 nice work! I just left a few minor comments
| import {faPencil, faTrashCan} from "@fortawesome/free-solid-svg-icons"; | ||
| import {FontAwesomeIcon} from "@fortawesome/react-fontawesome"; | ||
|
|
||
| import Table from "./table/table"; |
Collaborator
There was a problem hiding this comment.
This is good, but there are now unused imports that you can remove.
| }); | ||
| .then(json => json.data); | ||
| } | ||
| processData(data) { |
Collaborator
There was a problem hiding this comment.
Add a blank line before this method
| loading={this.state.loading} | ||
| noDataText={I18n.t("tas.empty_table")} | ||
| /> | ||
| <Table data={this.state.data} columns={this.columns} noDataText={I18n.t("tas.empty_table")} /> |
Collaborator
There was a problem hiding this comment.
Note that the data variable is defined immediately above this, so you can either delete that variable or just pass in data here.
| filterOptions: [ | ||
| { | ||
| value: "active", | ||
| text: `${I18n.t("roles.active")} (${this.state.counts.active})`, |
Collaborator
There was a problem hiding this comment.
@chickenwaddle77 one other thing I forgot to mention: because this part is being deleted, you can also get rid of the counts state attribute, which is no longer used.
merging with master branch
david-yz-liu
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Refactored the current react table v6 to react table v8. Functionality and he remains the same as before.
Details
Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)