Refactor context_menu.js #7563
Merged
Refactor context_menu.js #7563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Pull Request Test Coverage Report for Build 15722884691Details
💛 - Coveralls |
| import CreateTagModal from "../Modals/create_tag_modal"; | ||
| import {pathToNode} from "../Helpers/range_selector"; | ||
| import {ResultContext} from "./result_context"; | ||
| import {annotation_context_menu} from "../../../assets/javascripts/Results/context_menu"; |
Collaborator
There was a problem hiding this comment.
The change is good; however, please also move the file to app/javascript/Components/Result (since this file is only used by the Result component).
Changelog.md
Outdated
| - Remove the placeholder "..." text under the "Proposed changes" section in `PULL_REQUEST_TEMPLATE.md`. (#7524) | ||
| - Update the checklist in `PULL_REQUEST_TEMPLATE.md` to make the text "list of contributors" a link to the file in the repository. (#7524) | ||
| - Enabled `erb_lint` linter for erb files (#7561) | ||
| - Refactored the loading method of `javascripts/Results/context_menu.js`. |
Collaborator
There was a problem hiding this comment.
include the pull request number for this entry
david-yz-liu
approved these changes
Jun 18, 2025
Collaborator
|
Nice work, @freyazjiner 🎉 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
This PR modifies how context_menu.js is loaded by removing it from main.js and importing it directly into result.jsx where it's actually used. This change eliminates reliance on the global window.annotation_context_menu object.
Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)