Skip to content

Conversation

@donny-wong
Copy link
Contributor

@donny-wong donny-wong commented Apr 5, 2025

Proposed Changes

Currently, when assigning scans, it is not possible to assign to inactive students. We want to have this ability so that these scans do not continue to show up. The solution implemented is to have a checkbox for displaying inactive students, which would then allow us to assign scans to inactive students.
...

Screenshots of your changes (if applicable) This is how the `Display inactive student` checkbox would display: display inactive student checkbox

This is how an inactive student displays as an option:
inactive student

Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality) x
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@donny-wong donny-wong added this to the v2.6.2 milestone Apr 5, 2025
@donny-wong donny-wong linked an issue Apr 5, 2025 that may be closed by this pull request
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 14278142396

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 91.878%

Totals Coverage Status
Change from base Build 14275625251: 0.001%
Covered Lines: 41473
Relevant Lines: 44456

💛 - Coveralls

@donny-wong donny-wong requested a review from david-yz-liu April 7, 2025 15:09
@david-yz-liu david-yz-liu merged commit d1f3852 into MarkUsProject:master Apr 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to assign scans to inactive students

3 participants