Skip to content

Conversation

@donny-wong
Copy link
Contributor

@donny-wong donny-wong commented Mar 4, 2025

Proposed Changes

Currently, when we display the Autotester message, "Setting up test environment, Please try again later.", the flash styling is on alert-danger. This is actually not an error and it confuses the user thinking something went wrong. Instead we can use the notice alert style.

We had to modify the markus-autotesting component to respond with Http response instead of an exception. So we will need to make sure both these PRs are deployed together at the same time.
PR from markus-autotesting repo: MarkUsProject/markus-autotesting#589

...

Screenshots of your changes (if applicable)

Currently, it shows the message as an error message:
Screenshot 2025-03-03 at 11 07 23 PM

This PR will change the message to a notice flash message:
Screenshot 2025-03-03 at 11 06 26 PM

Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) x
🎨 User interface change (change to user interface; provide screenshots) x
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls
Copy link
Collaborator

coveralls commented Mar 4, 2025

Pull Request Test Coverage Report for Build 13769772469

Details

  • 14 of 16 (87.5%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 91.866%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/javascript/Components/submission_table.jsx 0 2 0.0%
Totals Coverage Status
Change from base Build 13769725436: 0.003%
Covered Lines: 41420
Relevant Lines: 44404

💛 - Coveralls

@donny-wong donny-wong force-pushed the setup_env_notice_flash_style_update branch from 7fde64c to 94e1407 Compare March 5, 2025 17:05
@donny-wong donny-wong marked this pull request as draft March 5, 2025 17:53
@donny-wong donny-wong added this to the v2.6.2 milestone Mar 6, 2025
@donny-wong donny-wong marked this pull request as ready for review March 7, 2025 20:58
@donny-wong donny-wong requested a review from david-yz-liu March 7, 2025 22:11
@donny-wong donny-wong force-pushed the setup_env_notice_flash_style_update branch from d72e68a to 82cee03 Compare March 10, 2025 14:27
@donny-wong donny-wong requested a review from david-yz-liu March 10, 2025 15:39
@david-yz-liu david-yz-liu merged commit 5d225d7 into MarkUsProject:master Mar 10, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants