Skip to content

Conversation

@donny-wong
Copy link
Contributor

@donny-wong donny-wong commented Feb 10, 2025

Proposed Changes

Currently we are grouping test results by test group name. If we have multiple test groups with the same name, the test results will be grouped all under that one test group name, rather than each test group having their own display grouping. To fix this, we will change to group by test group id.

...

Screenshots of your changes (if applicable)

E.g.: for this assignment we have 2 test groups with the same Test group name: "Python Test Group 1". With the fix in place, it displays properly with the test groups segregated in its own grouping as shown in the following screenshot:

fixed

Without the fix in place, we will see that the 2 test groups grouped as one under the group name "Python Test Group 1", which is not what we want:

prior to fix
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) x
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@donny-wong donny-wong changed the title group test results by Group Test ID Group test results by Test Groups ID Feb 10, 2025
@coveralls
Copy link
Collaborator

coveralls commented Feb 10, 2025

Pull Request Test Coverage Report for Build 13242996593

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.86%

Totals Coverage Status
Change from base Build 13222100238: 0.0%
Covered Lines: 41333
Relevant Lines: 44315

💛 - Coveralls

@david-yz-liu david-yz-liu merged commit 7a2a593 into MarkUsProject:master Feb 10, 2025
6 checks passed
@donny-wong donny-wong added this to the v2.6.2 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants