Skip to content

Conversation

@pranavrao145
Copy link
Contributor

@pranavrao145 pranavrao145 commented Nov 22, 2024

Proposed Changes

Closes #5178 by adding zoom and rotate functionality to the PDF viewer in both the Results View and file manager.

Screenshot:
image

Type of Change

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality) X
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

@coveralls
Copy link
Collaborator

coveralls commented Nov 22, 2024

Pull Request Test Coverage Report for Build 12059555175

Details

  • 20 of 22 (90.91%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 91.748%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/assets/javascripts/Components/Result/pdf_viewer.jsx 18 20 90.0%
Totals Coverage Status
Change from base Build 11987719101: 0.09%
Covered Lines: 41109
Relevant Lines: 44132

💛 - Coveralls

@pranavrao145 pranavrao145 force-pushed the feat/pdf-zoom branch 3 times, most recently from e1170ed to 1659494 Compare November 22, 2024 04:21
@pranavrao145 pranavrao145 marked this pull request as draft November 22, 2024 16:36
@pranavrao145
Copy link
Contributor Author

pranavrao145 commented Nov 22, 2024

Found a tiny UI problem, will fix it and re-submit this PR for review.

EDIT: fixed it!

@pranavrao145 pranavrao145 marked this pull request as ready for review November 22, 2024 17:14
@pranavrao145 pranavrao145 force-pushed the feat/pdf-zoom branch 2 times, most recently from 9843963 to cd39093 Compare November 22, 2024 17:15
Copy link
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranavrao145 great work!

@david-yz-liu david-yz-liu merged commit 6ddb4c4 into MarkUsProject:master Nov 28, 2024
6 checks passed
@pranavrao145 pranavrao145 deleted the feat/pdf-zoom branch November 28, 2024 20:16
@david-yz-liu david-yz-liu added this to the v2.6.1 milestone Dec 3, 2024
donny-wong pushed a commit to donny-wong/Markus that referenced this pull request Dec 6, 2024
donny-wong pushed a commit to donny-wong/Markus that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Zoom in / out functionality in pdf reader for graders

3 participants