-
Notifications
You must be signed in to change notification settings - Fork 251
PDF Zoom and Rotate Functionality #7306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
david-yz-liu
merged 5 commits into
MarkUsProject:master
from
pranavrao145:feat/pdf-zoom
Nov 28, 2024
Merged
PDF Zoom and Rotate Functionality #7306
david-yz-liu
merged 5 commits into
MarkUsProject:master
from
pranavrao145:feat/pdf-zoom
Nov 28, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Pull Request Test Coverage Report for Build 12059555175Details
💛 - Coveralls |
e1170ed to
1659494
Compare
Contributor
Author
|
Found a tiny UI problem, will fix it and re-submit this PR for review. EDIT: fixed it! |
9843963 to
cd39093
Compare
85a25fa to
a924b06
Compare
a924b06 to
9937439
Compare
9937439 to
522d66a
Compare
david-yz-liu
approved these changes
Nov 28, 2024
Collaborator
david-yz-liu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pranavrao145 great work!
donny-wong
pushed a commit
to donny-wong/Markus
that referenced
this pull request
Dec 6, 2024
donny-wong
pushed a commit
to donny-wong/Markus
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Closes #5178 by adding zoom and rotate functionality to the PDF viewer in both the Results View and file manager.
Screenshot:

Type of Change
Checklist
Before opening your pull request:
After opening your pull request: