Fixed Download One Time Annotation 'Not Found' error #7300
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donny-wong
changed the title
Collaborator
Pull Request Test Coverage Report for Build 11783665961Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
…oject#7293) * build(deps-dev): bump factory_bot_rails from 6.4.3 to 6.4.4 Bumps [factory_bot_rails](https://github.com/thoughtbot/factory_bot_rails) from 6.4.3 to 6.4.4. - [Release notes](https://github.com/thoughtbot/factory_bot_rails/releases) - [Changelog](https://github.com/thoughtbot/factory_bot_rails/blob/main/NEWS.md) - [Commits](thoughtbot/factory_bot_rails@v6.4.3...v6.4.4) --- updated-dependencies: - dependency-name: factory_bot_rails dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Revert rackup to v1.0.0 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Liu <david@cs.toronto.edu>
…t#7286) * build(deps): bump rails_performance from 1.2.2 to 1.2.3 Bumps [rails_performance](https://github.com/igorkasyanchuk/rails_performance) from 1.2.2 to 1.2.3. - [Release notes](https://github.com/igorkasyanchuk/rails_performance/releases) - [Changelog](https://github.com/igorkasyanchuk/rails_performance/blob/master/CHANGES.md) - [Commits](https://github.com/igorkasyanchuk/rails_performance/commits/1.2.3) --- updated-dependencies: - dependency-name: rails_performance dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Revert rackup to v1.0.0 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Liu <david@cs.toronto.edu>
* build(deps): bump rails from 7.2.1.1 to 7.2.2 Bumps [rails](https://github.com/rails/rails) from 7.2.1.1 to 7.2.2. - [Release notes](https://github.com/rails/rails/releases) - [Commits](rails/rails@v7.2.1.1...v7.2.2) --- updated-dependencies: - dependency-name: rails dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Revert rackup to v1.0.0 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Liu <david@cs.toronto.edu>
…t#7277) Bumps the rails group with 1 update: [@rails/actioncable](https://github.com/rails/rails). Updates `@rails/actioncable` from 7.2.100 to 7.2.200 - [Release notes](https://github.com/rails/rails/releases) - [Commits](https://github.com/rails/rails/commits) --- updated-dependencies: - dependency-name: "@rails/actioncable" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rails ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Contributor
Author
|
The pre-commit errors are related to Style/SafeNavigationChainLength, which is now addressed in the PR #7301 |
Collaborator
|
@donny-wong please pull the changes from master and then update this branch. Thanks! |
…-wong/Markus into one_time_annotation_page_not_found
Contributor
Author
|
We have a new PR for this issue found here: #7302 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
When trying to download the "One Time Only Annotations" for a certain course, it goes to the "Not Found" page. The reason for this is that there is a bug when creating this button link "One Time Only Annotations". It is passing an 'id' which would associate to a Categorized Annotation, and the value of the id is taken from the assignment's id. First, we are not considering a specific 'Categorized Annotation' and so we shouldn't be taking in an id, second issue is that the id that was passed was from an assignment id instead of a Categorized Annotation id.
...
Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)