-
Notifications
You must be signed in to change notification settings - Fork 251
Feature: Option to retain old grading data #7256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Option to retain old grading data #7256
Conversation
d6f138d to
896d896
Compare
3658acb to
76e1739
Compare
Pull Request Test Coverage Report for Build 11958705999Details
💛 - Coveralls |
ce5d579 to
aeadf2b
Compare
738cd52 to
19c19f7
Compare
1b64a1b to
295894a
Compare
0af67d5 to
01e0d63
Compare
01e0d63 to
934613f
Compare
david-yz-liu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pranavrao145, great work! I just did a quick review of the back-end implementation and left some comments. Please work on those, and then I'll do another review in a few days.
|
I'm just going to convert this back to a draft while I work on addressing comments just so it doesn't run tests on intermediate work, and I'll make it ready for review again once I'm finished! EDIT: back to ready now, but Jest tests still wrongly failing |
4478400 to
6bc11c5
Compare
…x annotation tests
25d0cd8 to
3a15291
Compare
3a15291 to
b6b69f8
Compare
david-yz-liu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pranavrao145 great job getting this completed! 🎉
Proposed Changes
Closes #5212.
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
Within inline comments.