Skip to content

Patch htmlparser2 instead of rely on MarkBind fork #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yamgent merged 6 commits into from
Dec 8, 2019
Merged

Patch htmlparser2 instead of rely on MarkBind fork #948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dcb1483
Update package-lock.json
acjh Dec 7, 2019
cd5c0f5
Limit js-beautify minor version to no output diff
acjh Dec 7, 2019
c108e19
Update htmlparser2 version to 3.10.1
acjh Dec 7, 2019
d4ef609
Patch htmlparser2 to treat Markdown code as text
acjh Dec 7, 2019
40ef545
Update npm version restriction to 6.12.1 or higher
acjh Dec 7, 2019
9549d54
Update troubleshooting answer to reflect fix
acjh Dec 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/devGuide/devGuide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
We expect contributors for MarkBind to have basic knowledge of the following:

* JavaScript (ES6)
* Node.js (LTS or higher) [with npm version of 5.8.0]
* Node.js (LTS or higher) [with npm version of 6.12.1 or higher]
* HTML & CSS
* Markdown
* Command-line environment
Expand Down Expand Up @@ -111,7 +111,7 @@ TypeError: Cannot set property 'src' of null
at Page.collectFrontMatter (~\markbind\src\Page.js:399:26)
```

A: If your npm version is v6.0.0 or higher, there is a change in behaviour on how npm install dependencies (see https://github.com/MarkBind/markbind/issues/582). To resolve this issue, discard the changes made by npm in `package-lock.json`, and redo `npm install`.
A: Please report this in a [new issue](https://github.com/MarkBind/markbind/issues/new), since this should already be fixed by [MarkBind/markbind#948](https://github.com/MarkBind/markbind/pull/948).

### Testing

Expand Down
Loading