Refactor page.ejs site template to be at src directory#937
Merged
yamgent merged 1 commit intoMarkBind:masterfrom Sep 13, 2019
Merged
Refactor page.ejs site template to be at src directory#937yamgent merged 1 commit intoMarkBind:masterfrom
yamgent merged 1 commit intoMarkBind:masterfrom
Conversation
Contributor
Author
|
Ready for review |
yamgent
approved these changes
Sep 13, 2019
Member
yamgent
left a comment
yamgent
left a comment
There was a problem hiding this comment.
Sorry for the late review, was busy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
Refactor
page.ejsto be at src directory as discussed in #935. This is becausetemplatedirectory is hijacked to include markbind initialized templates.In the near future, there seems to have no plans to have multiple base templates, as the design is very coupled with current base template in
page.ejs. If there are plans to decouple, we should consider refactoring again.