Skip to content

Add card stack count#2817

Merged
gerteck merged 4 commits intoMarkBind:masterfrom
Incogdino:feature-add-card-stack-count
Feb 5, 2026
Merged

Add card stack count#2817
gerteck merged 4 commits intoMarkBind:masterfrom
Incogdino:feature-add-card-stack-count

Conversation

@Incogdino
Copy link
Contributor

@Incogdino Incogdino commented Feb 1, 2026

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Closes #2808

Overview of changes:
Add count for the number of cards displayed on the card stack.

image

Anything you'd like to highlight/discuss:

Testing instructions:
npm run test

Proposed commit message: (wrap lines at 72 characters)
Add count to card stack component


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

@codecov
Copy link

codecov bot commented Feb 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.20%. Comparing base (41b471d) to head (5e4089c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2817      +/-   ##
==========================================
+ Coverage   72.18%   72.20%   +0.01%     
==========================================
  Files         134      134              
  Lines        7449     7454       +5     
  Branches     1622     1588      -34     
==========================================
+ Hits         5377     5382       +5     
  Misses       2026     2026              
  Partials       46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Incogdino Incogdino marked this pull request as ready for review February 1, 2026 13:03
@gerteck
Copy link
Member

gerteck commented Feb 1, 2026

Opps, I think that what I meant in the issue was beside the tags (e.g. Success (2) [ ] , Perservence (2) [ ])

Let me know if you think that owuld be a good idea!

@damithc
Copy link
Contributor

damithc commented Feb 3, 2026

Opps, I think that what I meant in the issue was beside the tags (e.g. Success (2) [ ] , Perservence (2) [ ])

Let me know if you think that owuld be a good idea!

Perhaps we do both i.e., show per-tag total and selected total ?

@yihao03
Copy link
Contributor

yihao03 commented Feb 4, 2026

I thought showing the total cards count is cool too. In that case I will attempt to take up showing per tag total

Copy link
Member

@gerteck gerteck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gerteck gerteck merged commit 2f6cb37 into MarkBind:master Feb 5, 2026
10 checks passed
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

@gerteck Each PR must have a SEMVER impact label, please remember to label the PR properly.

@gerteck gerteck added the r.Minor Version resolver: increment by 0.1.0 label Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r.Minor Version resolver: increment by 0.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Card Stack: Add count for each tag

4 participants