Fix issue with 404 page not working locally#2724
Open
AgentHagu wants to merge 2 commits intoMarkBind:masterfrom
Open
Fix issue with 404 page not working locally#2724AgentHagu wants to merge 2 commits intoMarkBind:masterfrom
AgentHagu wants to merge 2 commits intoMarkBind:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2724 +/- ##
=======================================
Coverage 52.84% 52.84%
=======================================
Files 130 130
Lines 7162 7162
Branches 1594 1501 -93
=======================================
Hits 3785 3785
Misses 3072 3072
Partials 305 305 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Personally, I'm not sure if this is the best fix because I'm not too familiar with the other middleware, such as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Partially fixes #2717
Adds an error handler to explicitly send the
404.htmlupon error 404. It removes the previous check forerr.status === 404and handles the error in a newly added middleware.Anything you'd like to highlight/discuss:
This PR only partially fixes #2717. It ensures that when serving the site locally, any invalid pages without a corresponding file will properly respond with the
404.htmlfile. It does not fix the current rendering issue with the default404.htmlfile causing it to be blank. That issue is related to #2716.Testing instructions:
markbind servehttp://127.0.0.1:8080/test404.htmlfile is shown as the response (To avoid Centre-align feature is not working #2716, this requires adjusting404.htmlsuch as removing the use of center-align)Proposed commit message: (wrap lines at 72 characters)
Fix issue with 404 page not working locally
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major,r.Minor,r.Patch.Breaking change release note preparation (if applicable):