Reimplement modal scrolling using Bootstrap's .modal-dialog-scrollable#2363
Merged
tlylt merged 3 commits intoMarkBind:masterfrom Aug 28, 2023
Merged
Reimplement modal scrolling using Bootstrap's .modal-dialog-scrollable#2363tlylt merged 3 commits intoMarkBind:masterfrom
tlylt merged 3 commits intoMarkBind:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2363 +/- ##
=======================================
Coverage 45.11% 45.11%
=======================================
Files 123 123
Lines 5165 5165
Branches 1086 1086
=======================================
Hits 2330 2330
Misses 2516 2516
Partials 319 319
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Resolves #2362
Reimplement PR #2322
Overview of changes:
We can directly use Bootstrap's provided class
.modal-dialog-scrollable(see https://getbootstrap.com/docs/5.1/components/modal/#scrolling-long-content), rather than the cumbersome way of adding custom styles (max-heightandoverflow-auto) previously done in PR #2322..modal-dialog-scrollableto modal-content.Anything you'd like to highlight/discuss:
Testing instructions:
Run
npm testto ensure snapshot tests are updated, andpackages/cli/test/functional/test_siteand runmarkbind serve -dtest_site/testModals.htmlin browser and test out Trigger for modal that should overflowProposed commit message: (wrap lines at 72 characters)
Reimplement scrolling using .modal-dialog-scrollable
Checklist: ☑️