Skip to content

Revert expand collapse all buttons #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlylt merged 5 commits into from
Jun 12, 2023
Merged

Revert expand collapse all buttons #2303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4e5f5ab
revert: collapse-expand-buttons component
itsyme Jun 3, 2023
d1f3360
test: update
itsyme Jun 3, 2023
93b7496
fix: update tests and layouts
itsyme Jun 3, 2023
a0d7ede
chore: undo package-lock.json change
itsyme Jun 3, 2023
647cb05
fix: syntax
itsyme Jun 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/_markbind/layouts/devGuide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
* [Style guides]({{baseUrl}}/devGuide/styleGuides.html)
</site-nav>
</div>
<collapse-expand-buttons />
</nav>
<div id="content-wrapper">
<breadcrumb />
Expand Down
1 change: 0 additions & 1 deletion docs/_markbind/layouts/userGuide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
* [Glossary]({{baseUrl}}/userGuide/glossary.html)
</site-nav>
</div>
<collapse-expand-buttons />
</nav>
<div id="content-wrapper">
<breadcrumb />
Expand Down
2 changes: 1 addition & 1 deletion docs/userGuide/components/others.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

<div id="overview" class="lead">

This page lists some other components that may be useful in creating education websites.
This page lists some other components that may be useful in creating education websites. For now, there are only question and quiz components.
Copy link
Contributor

@lhw-1 lhw-1 Jun 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that we removed this sentence in #2206 so it is being added back, but I am not sure if this sentence is really necessary 😅

</div>

{% from "userGuide/fullSyntaxReference.md" import syntax_topics as topics %}
Expand Down
3 changes: 1 addition & 2 deletions docs/userGuide/fullSyntaxReference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@
siteNavigationMenus : ['Site Navigation Menus', ['navigation', 'reader-facing']],
pageNavigationMenus : ['Page Navigation Menus', ['navigation', 'reader-facing']],
scrollTopButton : ['Scroll To Top Button', ['navigation', 'reader-facing']],
questions : ['Questions and Quizzes', ['others', 'reader-facing']],
collapseExpandButtons: ['Collapse/Expand All Buttons', ['others', 'reader-facing']]
questions : ['Questions and Quizzes', ['others', 'reader-facing']]
} %}

{% for topic in syntax_topics | dictsort %}
Expand Down
31 changes: 0 additions & 31 deletions docs/userGuide/syntax/collapseExpandButtons.md
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions docs/userGuide/syntax/siteNavigationMenus.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,4 @@ You can **append the `:expanded:` to a <tooltip content="a menu item with sub me

</div>

****Collapse/Expand All Buttons****

You can make expanding and collapsing dropdowns in the siteNav more accessible by using the [Collapse/Expand All Buttons]({{baseURl}}/userGuide/components/others.html#collapse-expand-all-buttons). These buttons are the `+` and `-` icons at the top right of the siteNav.

<div id="examples"></div>
1 change: 0 additions & 1 deletion packages/cli/test/functional/test_site_convert/test_basic_convert/expected/404.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
</overlay-source>
</site-nav>
</div>
<collapse-expand-buttons></collapse-expand-buttons>
</overlay-source>
<div id="content-wrapper">
<breadcrumb></breadcrumb>
Expand Down
2 changes: 1 addition & 1 deletion .../cli/test/functional/test_site_convert/test_basic_convert/expected/404.page-vue-render.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/cli/test/functional/test_site_convert/test_basic_convert/expected/Home.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@
</overlay-source>
</site-nav>
</div>
<collapse-expand-buttons></collapse-expand-buttons>
</overlay-source>
<div id="content-wrapper">
<breadcrumb></breadcrumb>
Expand Down
2 changes: 1 addition & 1 deletion ...cli/test/functional/test_site_convert/test_basic_convert/expected/Home.page-vue-render.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/cli/test/functional/test_site_convert/test_basic_convert/expected/Page-1.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@
</overlay-source>
</site-nav>
</div>
<collapse-expand-buttons></collapse-expand-buttons>
</overlay-source>
<div id="content-wrapper">
<breadcrumb></breadcrumb>
Expand Down
2 changes: 1 addition & 1 deletion ...i/test/functional/test_site_convert/test_basic_convert/expected/Page-1.page-vue-render.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/cli/test/functional/test_site_convert/test_basic_convert/expected/_Footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@
</overlay-source>
</site-nav>
</div>
<collapse-expand-buttons></collapse-expand-buttons>
</overlay-source>
<div id="content-wrapper">
<breadcrumb></breadcrumb>
Expand Down
2 changes: 1 addition & 1 deletion .../test/functional/test_site_convert/test_basic_convert/expected/_Footer.page-vue-render.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/cli/test/functional/test_site_convert/test_basic_convert/expected/_Sidebar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@
</overlay-source>
</site-nav>
</div>
<collapse-expand-buttons></collapse-expand-buttons>
</overlay-source>
<div id="content-wrapper">
<breadcrumb></breadcrumb>
Expand Down
Loading