Update DG to be consistent with default template#2288
Merged
tlylt merged 9 commits intoMarkBind:masterfrom Apr 17, 2023
Merged
Conversation
tlylt
requested changes
Apr 16, 2023
tlylt
approved these changes
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Updates the Onboarding Bootcamp to be consistent with changes made in #2225. Mainly wording and image updates to the Developer Guide.
Anything you'd like to highlight/discuss:
As the
pageNavof the frontmatter in the default template was changed from 2 to 4, I've modified the instructions to accommodate this change: instead of changing it from 2 to 1, the readers are now expected to try changing it from 4 to 5, which will show the sub-headings in the panel. I've also included a "before" image for this section to better highlight the differences. Following this, should we include a before vs after for all the relevant sections?Also, after the removal of
titlefromsite.jsonin #2128, thetitleproperty is not generated by default, so I've tweaked the wording to be more suitable (and included a panel to thesite.jsonpage in the UG for reference).While #2282 is related, I will not tackle it in this PR (for now) as it is possibly being tackled in another ongoing PR.
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Update DG to be consistent with default template
Checklist: ☑️