Add intra-site link instructions to docs#2276
Merged
itsyme merged 9 commits intoMarkBind:masterfrom Apr 10, 2023
Merged
Conversation
tlylt
requested changes
Apr 9, 2023
tlylt
requested changes
Apr 9, 2023
Contributor
tlylt
left a comment
tlylt
left a comment
There was a problem hiding this comment.
Can we include the rationale of why the tags work? (the part about using absolute link vs relative link)?
tlylt
approved these changes
Apr 9, 2023
lhw-1
approved these changes
Apr 10, 2023
Contributor
lhw-1
left a comment
lhw-1
left a comment
There was a problem hiding this comment.
LGTM! Just some wording nits :)
Co-authored-by: Lee Hyung Woon / 이형운 <leehyungwoonsamuel@gmail.com>
Co-authored-by: Lee Hyung Woon / 이형운 <leehyungwoonsamuel@gmail.com>
Co-authored-by: Lee Hyung Woon / 이형운 <leehyungwoonsamuel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Related to #2273. Added a section in "Contribute to Documentation" to explain the use tags when adding intra-site links. Added a box to "Implement a New Feature" to remind developers to use tags in intra-site links.
Anything you'd like to highlight/discuss:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Add intra-site link instructions to docs
Checklist: ☑️