Migrate Site/index.js to TypeScript#2270
Merged
jovyntls merged 2 commits intoMarkBind:masterfrom Apr 15, 2023
Merged
Conversation
jovyntls
force-pushed
the
ts-migrate-site-indexjs
branch
2 times, most recently
from
478bbd5 to
0f12a21
Compare
raysonkoh
reviewed
Apr 12, 2023
Contributor
raysonkoh
left a comment
raysonkoh
left a comment
There was a problem hiding this comment.
Thanks for the hardwork! Added some preliminary comments.
raysonkoh
reviewed
Apr 12, 2023
jovyntls
force-pushed
the
ts-migrate-site-indexjs
branch
2 times, most recently
from
9584d6b to
c598c07
Compare
13 tasks
jovyntls
force-pushed
the
ts-migrate-site-indexjs
branch
from
c598c07 to
1cd8034
Compare
tlylt
reviewed
Apr 14, 2023
jovyntls
force-pushed
the
ts-migrate-site-indexjs
branch
from
1cd8034 to
614999e
Compare
tlylt
reviewed
Apr 14, 2023
4 tasks
This was referenced Jul 16, 2023
Contributor
|
@tlylt as it will be quite a bit of work to undo the revert while keeping track of new PRs editing the file #2308 (comment), I suggest adding a small follow up comment on top that prohibits any changes to this file until this is fixed (and bumping the priority). The alternative is letting a portion of the typescript migration work go to waste (also an ok approach). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Part of #1913
Overview of changes:
Migrates Site/index.js to TS
Anything you'd like to highlight/discuss:
If we want to refactor how the methods at the end of Site/index.js are handled, I'd suggest we do a separate refactor of these methods after migrating this file to TS. Rationale of having these methods defined with
Site.prototype: see #979Testing instructions:
N/A
Proposed commit message: (wrap lines at 72 characters)
(rebase commit)
Checklist: ☑️