Fix backslash not working on non-windows machine#2255
Merged
EltonGohJH merged 1 commit intoMarkBind:masterfrom Apr 3, 2023
Merged
Fix backslash not working on non-windows machine#2255EltonGohJH merged 1 commit intoMarkBind:masterfrom
EltonGohJH merged 1 commit intoMarkBind:masterfrom
Conversation
eec1dde to
c6f35ff
Compare
lhw-1
approved these changes
Apr 3, 2023
Contributor
lhw-1
left a comment
There was a problem hiding this comment.
HI @EltonGohJH, thanks for the catch! LGTM :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Backslash does not work on non-windows machine.
To fix it I replace backslash with path.sep.
Fixes #2161
Anything you'd like to highlight/discuss:
Testing instructions:
Can try running on CS2103T site with non-windows machine.
Do note that there is some bug with CS2103T with non-windows machine due to naming.
I have created a PR there. (nus-cs2103-AY2223S2/website#1)
So for now, you might encounter some error message when serving cs2103t site on non-windows machine.
Proposed commit message: (wrap lines at 72 characters)
Checklist: ☑️