Skip to content

Fix backslash not working on non-windows machine#2255

Merged
EltonGohJH merged 1 commit intoMarkBind:masterfrom
EltonGohJH:elton/fix-backslash
Apr 3, 2023
Merged

Fix backslash not working on non-windows machine#2255
EltonGohJH merged 1 commit intoMarkBind:masterfrom
EltonGohJH:elton/fix-backslash

Conversation

@EltonGohJH
Copy link
Contributor

@EltonGohJH EltonGohJH commented Apr 1, 2023

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:
Backslash does not work on non-windows machine.
To fix it I replace backslash with path.sep.
Fixes #2161

Anything you'd like to highlight/discuss:

Testing instructions:
Can try running on CS2103T site with non-windows machine.
Do note that there is some bug with CS2103T with non-windows machine due to naming.
I have created a PR there. (nus-cs2103-AY2223S2/website#1)
So for now, you might encounter some error message when serving cs2103t site on non-windows machine.

Proposed commit message: (wrap lines at 72 characters)

Fix backslash not working on non-windows machine

Currently, backslash is not supported on Markbind. So, non-windows
user will encounter error when including file with backslash.

We can fix the changing backslash to forwardslash of the include path.

This will allow non-windows user to be able to serve website on Markbind 
when they use forwardslash.

This change resolves the following issue:
* #2161: Back slash not working for include path when using Markbind 4+

Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@EltonGohJH EltonGohJH force-pushed the elton/fix-backslash branch from eec1dde to c6f35ff Compare April 1, 2023 14:49
@EltonGohJH EltonGohJH requested a review from a team April 1, 2023 14:50
Copy link
Contributor

@lhw-1 lhw-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @EltonGohJH, thanks for the catch! LGTM :)

@EltonGohJH EltonGohJH merged commit 2c8c938 into MarkBind:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Back slash not working for include path when using Markbind 4+

2 participants