Skip to content

[WIP] Migrate Site/index.js to TypeScript#2210

Closed
lhw-1 wants to merge 1 commit intoMarkBind:masterfrom
lhw-1:1913-typescript-site
Closed

[WIP] Migrate Site/index.js to TypeScript#2210
lhw-1 wants to merge 1 commit intoMarkBind:masterfrom
lhw-1:1913-typescript-site

Conversation

@lhw-1
Copy link
Contributor

@lhw-1 lhw-1 commented Mar 13, 2023

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:

Note: This PR is on hold until #2164 has been merged (we can avoid messy conflicts if the Layout file is migrated to TypeScript before this).

Part of #1913.

Migrates Site/index.js to TypeScript.

Anything you'd like to highlight/discuss:

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@lhw-1 lhw-1 closed this Mar 13, 2023
@lhw-1 lhw-1 force-pushed the 1913-typescript-site branch from 6e686d0 to 161eb2f Compare March 13, 2023 18:18
@lhw-1 lhw-1 reopened this Mar 14, 2023
@lhw-1 lhw-1 marked this pull request as draft March 14, 2023 01:26
@lhw-1 lhw-1 changed the title Migrate Site/index.js to TypeScript [WIP] Migrate Site/index.js to TypeScript Mar 20, 2023
@lhw-1 lhw-1 force-pushed the 1913-typescript-site branch 2 times, most recently from c4b234f to 5567a08 Compare March 22, 2023 11:00
@lhw-1 lhw-1 force-pushed the 1913-typescript-site branch from 5567a08 to b2e9e92 Compare March 22, 2023 11:01
@lhw-1
Copy link
Contributor Author

lhw-1 commented Apr 3, 2023

Closing this first in favor of incrementally refactoring Site/index.js first, which will also be better for the TypeScript migration afterwards.

@lhw-1 lhw-1 closed this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant