Document cyclical error in include in UG#2198
Merged
tlylt merged 10 commits intoMarkBind:masterfrom Mar 10, 2023
Merged
Conversation
Contributor
|
As this is a rare case (i.e., most users will not need to know about it), we should present it in a way most readers are not forced to read it but they can locate this information when they need to. Any ideas? |
Contributor
|
Thank you @yucheng11122017 for taking this up. Could we:
|
tlylt
reviewed
Mar 8, 2023
tlylt
reviewed
Mar 8, 2023
tlylt
approved these changes
Mar 8, 2023
Contributor
tlylt
left a comment
There was a problem hiding this comment.
LGTM, fixed a typo and added line numbers for consistency within the panel.
damithc
reviewed
Mar 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Documents #2177
Overview of changes:
Added a warning about the cyclical error in includes when variables have the same name. Included suggested solution for this bug.
Anything you'd like to highlight/discuss:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Document cyclical error in include in UGChecklist: ☑️