Skip to content

Migrate core/src/html tests to TypeScript#2192

Merged
jovyntls merged 2 commits intoMarkBind:masterfrom
jovyntls:ts-migrate-core-tests
Mar 14, 2023
Merged

Migrate core/src/html tests to TypeScript#2192
jovyntls merged 2 commits intoMarkBind:masterfrom
jovyntls:ts-migrate-core-tests

Conversation

@jovyntls
Copy link
Contributor

@jovyntls jovyntls commented Feb 27, 2023

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Part of #1913

Overview of changes:
Migrate the tests associated with core/src/html files to TS

Anything you'd like to highlight/discuss:
N/A

Proposed commit message: (wrap lines at 72 characters)
(rebase commit)


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

jovyntls added a commit to jovyntls/markbind that referenced this pull request Feb 27, 2023
@jovyntls jovyntls force-pushed the ts-migrate-core-tests branch from 8a11043 to f3ae90a Compare February 27, 2023 13:56
@jovyntls jovyntls force-pushed the ts-migrate-core-tests branch from f3ae90a to ffd6614 Compare March 5, 2023 15:09
@jovyntls jovyntls requested a review from raysonkoh March 7, 2023 02:56
Copy link
Contributor

@raysonkoh raysonkoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jovyntls jovyntls added this to the v4.1.1 milestone Mar 14, 2023
@jovyntls jovyntls merged commit c4abfe0 into MarkBind:master Mar 14, 2023
@jovyntls jovyntls deleted the ts-migrate-core-tests branch March 14, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants