Support iconColor in box when light/seamless is used#2178
Merged
jovyntls merged 3 commits intoMarkBind:masterfrom Feb 23, 2023
Merged
Support iconColor in box when light/seamless is used#2178jovyntls merged 3 commits intoMarkBind:masterfrom
jovyntls merged 3 commits intoMarkBind:masterfrom
Conversation
jovyntls
approved these changes
Feb 21, 2023
Contributor
jovyntls
left a comment
jovyntls
left a comment
There was a problem hiding this comment.
LGTM with comprehensive tests!
…onColorOverride
jovyntls
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Fixes #2174
Overview of changes:
Add !important to custom icon color to override default colors.
Anything you'd like to highlight/discuss:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Support iconColor in box when light/seamless is usedChecklist: ☑️