Update headings to match sidebar#2152
Conversation
yucheng11122017
left a comment
There was a problem hiding this comment.
Thanks for the work @itsyme!
For user guide, the .gitignore file and glossary doesn't match as well.
For the dev guide, the introduction (under onboarding bootcamp) doesn't match.
DG the subpages under the github actions are titled "GitHub Actions: {{title}}". Same for subpage in Appendices. Not sure if this should be changed?
docs/userGuide/components/popups.md
Outdated
| <include src="advanced.md#slots-info" /> | ||
|
|
||
| # Pop-Up Components | ||
| # Using Components: Pop-ups |
There was a problem hiding this comment.
Small nit: Should be Pop-Ups according to side bar
|
Thanks for the detailed review @yucheng11122017 !! I have made the relevant changes in the latest commit. For Onboarding Bootcamp -> Introduction, . As for "GitHub Actions: |
Yup agree! It seems like only sub headings (like under components) have the {{ heading }}: {{ title }} format while the rest all use {{ title }} |
Maybe this would be changed to {{ title }} to follow the rest |
|
Hi @yucheng11122017! I think that's a great suggestion! However, I think this may be out of scope for this PR. Perhaps it could be good to open a new issue/PR to address this issue! |
|
What do you think of not having the |
Since Prof is ok with it, @itsyme maybe you can update? |
|
Alright! I think that is cleaner as well. I will update it in the next commit! |
|
Hi @yucheng11122017! I realised I have not resolved your comment about developer guide -> onboarding bootcamp -> introduction. I left the title as "Onboarding Bootcamp" as I felt that putting "Introduction" alone for the title might be a little too vague. What do you think? |
Yeah good point! Concur with you on that then |

What is the purpose of this pull request?
Overview of changes:
Resolves #2150. All headers which did not match the title in the sidebar were changed for both the User Guide and Developer Guide.
Anything you'd like to highlight/discuss:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Update headings to match sidebar
Checklist: ☑️