Migrate linkProcessor and SiteLinkManager to TypeScript#2149
Merged
jovyntls merged 2 commits intoMarkBind:masterfrom Feb 14, 2023
Merged
Migrate linkProcessor and SiteLinkManager to TypeScript#2149jovyntls merged 2 commits intoMarkBind:masterfrom
jovyntls merged 2 commits intoMarkBind:masterfrom
Conversation
jovyntls
force-pushed
the
ts-migrate-linkprocessors
branch
from
dbd70d0 to
dccacd8
Compare
jovyntls
force-pushed
the
ts-migrate-linkprocessors
branch
from
dccacd8 to
90a0e20
Compare
jovyntls
changed the title
jovyntls
changed the title
jovyntls
force-pushed
the
ts-migrate-linkprocessors
branch
from
90a0e20 to
a266983
Compare
jovyntls
force-pushed
the
ts-migrate-linkprocessors
branch
from
a266983 to
9a75a80
Compare
raysonkoh
reviewed
Feb 13, 2023
raysonkoh
approved these changes
Feb 13, 2023
Contributor
raysonkoh
left a comment
raysonkoh
left a comment
There was a problem hiding this comment.
LGTM, other than a minor nit
jovyntls
force-pushed
the
ts-migrate-linkprocessors
branch
from
9a75a80 to
5d0d5d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Part of #1913
Overview of changes:
Migrates linkProcessor and SiteLinkManager to TS
Anything you'd like to highlight/discuss:
N/A
Testing instructions:
N/A
Proposed commit message: (wrap lines at 72 characters)
N/A - rebase commit
Checklist: ☑️