Update Typescript migration documentation for Merging#2134
Merged
tlylt merged 7 commits intoMarkBind:masterfrom Feb 27, 2023
Merged
Update Typescript migration documentation for Merging#2134tlylt merged 7 commits intoMarkBind:masterfrom
tlylt merged 7 commits intoMarkBind:masterfrom
Conversation
ong6
changed the title
raysonkoh
reviewed
Feb 5, 2023
tlylt
reviewed
Feb 5, 2023
Contributor
tlylt
left a comment
tlylt
left a comment
There was a problem hiding this comment.
Would be nice if we can add some screenshots to show the exact steps and the expected outcome, so as to reduce unnecessary mental stress.
Co-authored-by: Jovyn Tan <61113575+jovyntls@users.noreply.github.com>
Co-authored-by: Jovyn Tan <61113575+jovyntls@users.noreply.github.com>
Co-authored-by: Jovyn Tan <61113575+jovyntls@users.noreply.github.com>
tlylt
dismissed
jovyntls’s stale review
Since this part is not adjusted, dismissing to avoid accidentally merging this PR. https://github.com/MarkBind/markbind/pull/2134/files#r1104142805
tlylt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Update the dev docs regarding typescript migration to use rebase and merge instead of normal merge.
Anything you'd like to highlight/discuss:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Update Typescript migration documentation for Merging
Checklist: ☑️