Merged
Conversation
Contributor
|
Would we need to capture the file path here as well? |
Contributor
Author
|
We need to capture the missing target and boilerplate file source in either the try-catch block or when checking the file exists (No need for both) I placed it in the else block when checking for the file exists since the other sources are collected there |
acjh
approved these changes
Mar 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File A includes File B which does not exist (e.g. due to a typo).
When File B is added, in the current markbind-cli, we will rebuild all files and this will update all files including A.
If we want to only rebuild file A when B is added, we should keep missing include file sources as well.