Skip to content

Replace deprecated set-output with GITHUB_OUTPUT #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlylt merged 7 commits into from
Apr 13, 2023
Merged

Replace deprecated set-output with GITHUB_OUTPUT #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e7cabf8
[WIP] Change to use GITHUB_OUTPUT for PR number
yucheng11122017 Mar 28, 2023
7811163
Change formating for pr number
yucheng11122017 Mar 28, 2023
f6ebd43
Change brackets for cat
yucheng11122017 Mar 28, 2023
7b4a714
Change to use set-output for PR link
yucheng11122017 Mar 28, 2023
c2f5f53
Replace set-output in unpublish-preview
yucheng11122017 Mar 28, 2023
51f1d56
Change peter-evans find comment to v2
yucheng11122017 Apr 13, 2023
588d910
Update version of peter-evans/create-or-update-comment
yucheng11122017 Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/fork-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
path: .
- name: Extract PR number
id: pr-number
run: echo '::set-output name=ACTIONS_PR_NUMBER::'$(cat ./pr/NUMBER)
run: echo "ACTIONS_PR_NUMBER=$(cat ./pr/NUMBER)" >> $GITHUB_OUTPUT
- name: Install Node
uses: actions/setup-node@v2
with:
Expand All @@ -36,22 +36,22 @@ jobs:
id: pr-url
run: |
PR_URL="https://pr-${{ steps.pr-number.outputs.ACTIONS_PR_NUMBER }}-${{ inputs.domain }}"
echo '::set-output name=ACTIONS_PREVIEW_URL::'$PR_URL
echo "ACTIONS_PREVIEW_URL=${PR_URL}" >> $GITHUB_OUTPUT
- name: Install surge and deploy PR to surge
run: |
npm i -g surge
surge --project ./curr-repo/_site --domain ${{ steps.pr-url.outputs.ACTIONS_PREVIEW_URL }}
env:
SURGE_TOKEN: ${{ secrets.token }}
- name: Find existing PR preview link comment
uses: peter-evans/find-comment@v1
uses: peter-evans/find-comment@v2
id: fc
with:
issue-number: ${{ steps.pr-number.outputs.ACTIONS_PR_NUMBER }}
body-includes: Your PR can be previewed
- name: Comment PR preview link in PR
if: ${{ steps.fc.outputs.comment-id == 0 }}
uses: peter-evans/create-or-update-comment@v1
uses: peter-evans/create-or-update-comment@v2
with:
issue-number: ${{ steps.pr-number.outputs.ACTIONS_PR_NUMBER }}
body: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/unpublish-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,22 +25,22 @@ jobs:
id: pr-url
run: |
PR_URL="https://pr-${{ github.event.number }}-${{ inputs.domain }}"
echo '::set-output name=ACTIONS_PREVIEW_URL::'$PR_URL
echo "ACTIONS_PREVIEW_URL=${PR_URL}" >> $GITHUB_OUTPUT
- name: Install surge and teardown
run: |
npm i -g surge
surge teardown --domain ${{ steps.pr-url.outputs.ACTIONS_PREVIEW_URL }}
env:
SURGE_TOKEN: ${{ secrets.token }}
- name: Find existing PR preview link comment
uses: peter-evans/find-comment@v1
uses: peter-evans/find-comment@v2
id: fc
with:
issue-number: ${{ github.event.number }}
body-includes: Your PR preview site has been torn down
- name: Comment PR preview torn down in PR
if: ${{ steps.fc.outputs.comment-id == 0 }}
uses: peter-evans/create-or-update-comment@v1
uses: peter-evans/create-or-update-comment@v2
with:
issue-number: ${{ github.event.number }}
body: |
Expand Down
4 changes: 2 additions & 2 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,14 +114,14 @@ runs:
SURGE_TOKEN: ${{ inputs.token }}
- name: Find existing PR preview link comment
if: inputs.service == 'surge' && inputs.purpose == 'pr-preview' && github.event_name == 'pull_request'
uses: peter-evans/find-comment@v1
uses: peter-evans/find-comment@v2
id: fc
with:
issue-number: ${{ env.prNum }}
body-includes: Your PR can be previewed
- name: Comment PR preview link in PR
if: inputs.service == 'surge' && inputs.purpose == 'pr-preview' && github.event_name == 'pull_request' && steps.fc.outputs.comment-id == 0
uses: peter-evans/create-or-update-comment@v1
uses: peter-evans/create-or-update-comment@v2
with:
issue-number: ${{ env.prNum }}
body: |
Expand Down