SE-1673:- Adds logic to prevent IE scrollbar drag bug. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• vaadin-combo-box was forked to introduce this fix. • vaadin-combo-box could not be updated to 2.0.0 where the fix is made because the updating across multiple dependencies would be too expensive. • the fix for this bug was taken from commit 9f5897d - Fix overlay scrolling via the scrollbar in IE. • only the single line from vaadin-combo-box-behavior.html was necessary. • branch 1.x was started from tag 1.3.3 (the original 1.x branch before we forked had 18 additional commits that we didn't care about)
terrencebowen
requested review from
9kinds,
PerpetualChange,
chuckhousley,
haydenmcp,
jay8t6,
jbforth4,
kewalter,
laurkatz13,
leelakrish,
mandymichel and
ZempTime
and removed request for
jay8t6
jbforth4
approved these changes
Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• vaadin-combo-box was forked to introduce this fix.
• vaadin-combo-box could not be updated to 2.0.0 where the fix is made because the updating across multiple dependencies would be too expensive.
• the fix for this bug was taken from commit 9f5897d - Fix overlay scrolling via the scrollbar in IE.
• only the single line from vaadin-combo-box-behavior.html was necessary.
• branch 1.x was started from tag 1.3.3 (the original 1.x branch before we forked had 18 additional commits that we didn't care about)