Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for E1743 #1

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Update for E1743 #1

merged 2 commits into from
Nov 13, 2023

Conversation

MarijnDoeve
Copy link
Owner

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Breaking change

If your PR contains a breaking change for existing users, it is important to describe what breaks, how to make it work again and why we did this. This section will be used to craft the changelog entry, after your PR gets approved and merged.

Note: Remove this section if this PR is NOT a breaking change.

Proposed change*

Describe the big picture of your changes here, and why your pull request should be accepted. If it fixes a bug or resolves a feature request, be sure to put closes #XXXX in this section to auto-close relevant issues.

Please note that for important and breaking changes it's always better to open an issue first for discussing the proposal.

Make sure to provide enough information so that your pull request can be reviewed.

Checklist*

  • I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • I properly tested proposed changes on my system and confirm that they are working as expected.
  • I formatted files with Prettier using the command npm run format before submitting my Pull Request.

Change mapping for long press and releasing after long press actions.
Update ZHA long press buttons mapping for ikea_e1743.yaml
@MarijnDoeve MarijnDoeve merged commit 945a9f3 into MarijnDoeve:main Nov 13, 2023
4 of 5 checks passed
Copy link

Hey @TheRijn, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

Copy link

github-actions bot commented Nov 13, 2023

Hey @TheRijn,

❌ It looks like there are some issues with your contribution. Don't worry, here's some additional information and guidance on how to solve them.

  • Your files are not properly formatted. Did you remember to run npm run format before submitting your changes?

Please fix reported issues, then submit your updates here. If you have any questions or doubts, you can always contact a project maintainer. :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants