Add the panel background color as a customizable option in theme.conf #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From https://github.com/github/gitignore/blob/master/Qt.gitignore. My setup for testing this theme was to run `sddm-greeter --test-mode --theme <Path to this repo>`, which generated many .qmlc files. These shouldn't be tracked. Rather than create a .gitignore with just `*.qmlc` I figured it's best to use the community's standard .gitignore for Qt.
I tweaked the theme to my liking but found that the panel background was too similar to the theme colors I chose so everything was unreadable. I liked the colors so I figured I'd change the panel background. Now this option is exposed to users.
|
I was looking for this feature so deeply! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tweaked the theme to my liking but found that the panel background was too similar to the theme
colors I chose which made everything was unreadable. I liked the colors I had picked so I figured I'd change the panel background. Now this option is exposed to users. I left the color in
theme.confas the original#444444instead of an SVG color name because 1.) none of the SVG grays were quite as dark and 2.) it shows users an example of a hex color entry.I also added the community standard Qt .gitignore file. When testing this theme with
sddm-greeter --test-mode --theme <Path to theme>, .qmlc files were generated and showed up in git. These need not be tracked as they are just compiled forms of the .qml files.Attached are the colors I had tried to use initially as well as the colors with a custom, darker background: