MDEV-38120: Move Json_string and Json_saved_parser_state into sql_json_lib.h #4447
+78
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Make the commit title be: |
spetrunia
approved these changes
Nov 20, 2025
Member
spetrunia
left a comment
spetrunia
left a comment
There was a problem hiding this comment.
Address input above and good to push.
Member
|
Get this pushed, |
bsrikanth-mariadb
changed the title
bsrikanth-mariadb
force-pushed
the
12.3-mdev-38120-create-sql_json_lib-file
branch
3 times, most recently
from
4120cc7 to
c77eaf2
Compare
…n_lib.h Move classes Json_string, and Json_saved_parser_state from opt_histogram_json.cc to the newly created file sql_json_lib.h Additionally, make the function json_unescape_to_string public earlier defined as static in opt_histogram_json.cc, by adding the declaration in sql_json_lib.h Needed this change so that, the classes and functions can be reused in other pieces of the code.
bsrikanth-mariadb
force-pushed
the
12.3-mdev-38120-create-sql_json_lib-file
branch
from
c77eaf2 to
e96fd4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move classes Json_string, and Json_saved_parser_state from opt_histogram_json.cc to the newly created file sql_json_lib.h Additionally, make the function json_unescape_to_string public earlier defined as static in opt_histogram_json.cc, by
adding the declaration in sql_json_lib.h
Needed this change so that, the classes and functions can be reused in other pieces of the code.