MDEV-37969 sphinx_snippets() UDF fails to resolve hostname #4407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
The SphinxSE sphinx_snippets had a erronous test condition on the getaddrinfo return value. With this inverted there was always an error. The entire CSphUrl::Connect also failed to handle IPv6 addresses. As getaddrinfo can return multiple addresses it makes sense to try each of these. Performing freeaddrinfo(hp) on an error condition in getaddrinfo caused a SEGV. Removed some boilerplate #ifdef around very old MySQL versions and unused defines. This sphinx tests reuse the parsing of configuration files from the test My::Config packaging, which needed to change as sphinx supports multiple listen directives needed for the test. Without this the last specified listen only was recorded in the configuration file. charset_type removed the indexer reported 2.2.11: WARNING: key 'charset_type' was permanently removed from Sphinx configuration. Thanks to bug report by Misagh Laghaei who kindly refered me to manticoresoftware/manticoresearch#3804 by Sergey Nikolaev <prostuda@academ.org> that showed showed the getaddrinfo handling errors, and other odd handling of connection code.
grooverdan
force-pushed
the
MDEV-37969-sphinx
branch
from
3a973b9 to
f00e129
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SphinxSE sphinx_snippets had a erronous test condition on the getaddrinfo return value. With this inverted there was always an error.
The entire CSphUrl::Connect also failed to handle IPv6 addresses. As getaddrinfo can return multiple addresses it makes sense to try each of these.
Performing freeaddrinfo(hp) on an error condition in getaddrinfo caused a SEGV.
Removed some boilerplate #ifdef around very old MySQL versions and unused defines.
Thanks to bug report by Misagh Laghaei who kindly refered me to manticoresoftware/manticoresearch#3804 by Sergey Nikolaev prostuda@academ.org that showed showed the getaddrinfo handling errors, and other odd handling of connection code.
Release Notes
TODO: What should the release notes say about this change?
Include any changed system variables, status variables or behaviour. Optionally list any https://mariadb.com/kb/ pages that need changing.
How can this PR be tested?
sphinx.sphinxtest case.If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.
Basing the PR against the correct MariaDB version
mainbranch.PR quality check