Skip to content

Make log files support utf8, /usr/bin/mariadbd-multi, MDEV-37630 #4295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make log files support utf8, /usr/bin/mariadbd-multi, MDEV-37630 #4295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/mysqld_multi.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ sub w2log

open (LOGFILE, ">>$opt_log")
or die "FATAL: w2log: Couldn't open log file: $opt_log\n";

binmode(LOGFILE, ":encoding(UTF-8)");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to be enough. If locale is set to something non-utf8, perl binmode will screw up the string:

LC_TIME="zh_CN.GB18030" perl -e 'use POSIX qw(strftime); open (LOGFILE, ">>log"); binmode(LOGFILE, ":encoding(UTF-8)"); print LOGFILE strftime "%a %b %e %H:%M:%S %Y\n", localtime; close(LOGFILE);'
iconv -f gb18030 -t utf8 < log

This simplest solution would be to change date format such that it doesn't contain non-ASCII characters, e.g %Y-%m-%d %H:%M:%S. Another option is to preserve date format, but use something else instead of strftime() like Time::Piece or DateTime.

if ($is_file)
{
open (FROMFILE, "<$msg") && (@data=<FROMFILE>) &&
Expand Down