MDEV-28103 container /docker-entrypoint-initdb.d sql on master doesn't replicate #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t replicate A user wants to initialize the master with a bunch of SQL to be replicated doesn't get binary logged due to the --skip-log-bin on the temporary server start. The commit that this reverts added the skip-log-bin to speed up timezones. A later commit 013d851 speed up the timezone initialization by disabling binary logs when timezones where loaded. The mariadb-upgrade does set `SET SQL_LOG_BIN=0` by default. As such: Revert "MDEV-27074: disable log-bin during temp server start" This reverts commit 146e09c. Thanks Markus Mäkelä for the bug report.
grooverdan
added a commit
to grooverdan/official-images
that referenced
this pull request
Mar 17, 2022
A regression that a container master doesn't contain the binary logs of its initdb.d data and cannot replicate this. Fix details: MariaDB/mariadb-docker#421.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary testing image pushed to quay.io/danielgblack/mariadb-test:10.6-MDEV-28103
summary:
A user wants to initialize the master with a bunch of SQL to be
replicated doesn't get binary logged due to the --skip-log-bin
on the temporary server start.
The commit that this reverts added the skip-log-bin to speed up
timezones. A later commit 013d851
speed up the timezone initialization by disabling binary logs
when timezones where loaded.
The mariadb-upgrade does set
SET SQL_LOG_BIN=0by default.As such:
Revert "MDEV-27074: disable log-bin during temp server start"
This reverts commit 146e09c.