MDBF-424: fix missing grant and zoneinfo for tests

[an3l]

• Check the issue MDBF-424: Multiple problems when running the tests #5 for problem statment
• After the patch

$ ./manage.py test
Creating test database for alias 'default'...
System check identified no issues (0 silenced).
.......
----------------------------------------------------------------------
Ran 7 tests in 0.421s

OK
Destroying test database for alias 'default'...

[cvicentiu]

Hi Anel!
You bring up a good point in that users might expect to run this code with Python versions lower than 3.9. However, changing the code to account for this is not something desirable. We are not going to run the code in production on anything that is not specified in the docker file and the code will not get tested in an different environment either.

As such, this ZoneInfo change is guaranteed to remain untested. I do not want to have this in the code base. Thus we should update the README file to properly set those expectations.

There is a reason why the current dev setup requires docker-compose. This ensures a uniform environment for all developers as well as the same environment that will be used in production.

The grant alter command is also wrong. The reason why you got the error in the first place is because you had a local MariaDB database instance when you ran the tests locally, not within the docker container. And that local database didn't grant the complete rights, like create_database_user.py does. Notice the next command at
cec59ac#diff-66a42c0ee250b38d7c0c694d6b7f820a8a1788000325f90b319405985249505dR45

This one grants rights on test_{} database, rights which imply ALTER.
The reason why CREATE is granted on the global level is for the user to be able to run CREATE DATABASE test_.... command

Thus, please change the PR to only document this intended workflow. Optionally, after PR #5 gets merged, one can document which variables to set to configure DJANGO to connect to another database, not the one running inside the container.

[an3l]

Hi @cvicentiu,
thanks for looking into this.
I have some questions and remarks:

• I'm not sure I understood, you want to support product only for usage with containers, not for local instantiation? That that would mean that MDBF-421: Create documentation in Readme.md how to start properly locally (from virtual env) #4 is not needed at all?
• I don't have problem with having latest version of python and update the readme, but since this change is the only one that depends on the latest version I would vote to support that too (+ other if any changes are related).
• grant alter is fixing the test and also fixing the CI (see PR MDBF-423: Change default connection to database to use host different than dock… #3 that is failing).
  I gave all grants to my local user based on the the example of docker/mariadb/create_database_user.py script and if you see MDBF-424: Multiple problems when running the tests #5 the failing database is django_content_type that is result of migration, the test_feedback_plugin DB is not affected (since I gave correct rights).