Skip to content

HTTP/3: initialize Host header from :authority to enable $http_host variable #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarcoMarcoaldi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HTTP/3: initialize Host header from :authority to enable $http_host variable #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 51 additions & 10 deletions src/http/v3/ngx_http_v3_request.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ static ngx_int_t ngx_http_v3_do_read_client_request_body(ngx_http_request_t *r);
static ngx_int_t ngx_http_v3_request_body_filter(ngx_http_request_t *r,
ngx_chain_t *in);

static ngx_int_t ngx_http_v3_set_host(ngx_http_request_t *r, ngx_str_t *value); // Enable $http_host


static const struct {
ngx_str_t name;
Expand Down Expand Up @@ -998,6 +1000,35 @@ ngx_http_v3_init_pseudo_headers(ngx_http_request_t *r)
}


static ngx_int_t

ngx_http_v3_set_host(ngx_http_request_t *r, ngx_str_t *value)
{
ngx_table_elt_t *h;

static ngx_str_t host = ngx_string("host");

h = ngx_list_push(&r->headers_in.headers);
if (h == NULL) {
return NGX_ERROR;
}

h->hash = ngx_hash(ngx_hash(ngx_hash('h', 'o'), 's'), 't');

h->key.len = host.len;
h->key.data = host.data;

h->value.len = value->len;
h->value.data = value->data;

h->lowcase_key = host.data;

r->headers_in.host = h;
h->next = NULL;

return NGX_OK;
}

static ngx_int_t
ngx_http_v3_process_request_header(ngx_http_request_t *r)
{
Expand Down Expand Up @@ -1035,22 +1066,33 @@ ngx_http_v3_process_request_header(ngx_http_request_t *r)
goto failed;
}

if (r->headers_in.host && r->host_end) {

if (r->host_end) {
/* full :authority value (possibly with port) */
host.len = r->host_end - r->host_start;
host.data = r->host_start;

if (r->headers_in.host->value.len != host.len
|| ngx_memcmp(r->headers_in.host->value.data, host.data, host.len)
!= 0)
{
ngx_log_error(NGX_LOG_INFO, c->log, 0,
"client sent \":authority\" and \"Host\" headers "
"with different values");
goto failed;
if (r->headers_in.host) {
/* both Host and :authority present - ensure they are equal */
if (r->headers_in.host->value.len != host.len
|| ngx_memcmp(r->headers_in.host->value.data,
host.data, host.len) != 0)
{
ngx_log_error(NGX_LOG_INFO, c->log, 0,
"client sent \":authority\" and \"Host\" headers "
"with different values");
goto failed;
}
} else {
/* Host is missing - set from :authority */
if (ngx_http_v3_set_host(r, &host) != NGX_OK) {
ngx_http_close_request(r, NGX_HTTP_INTERNAL_SERVER_ERROR);
return NGX_ERROR;
}
}
}


if (r->headers_in.content_length) {
r->headers_in.content_length_n =
ngx_atoof(r->headers_in.content_length->value.data,
Expand Down Expand Up @@ -1488,7 +1530,6 @@ ngx_http_v3_do_read_client_request_body(ngx_http_request_t *r)
return NGX_OK;
}


static ngx_int_t
ngx_http_v3_request_body_filter(ngx_http_request_t *r, ngx_chain_t *in)
{
Expand Down