Skip to content

Add basic typechecking - #72

Merged
MarcellPerger1 merged 126 commits into
mainfrom
add-typechecking
Jul 23, 2026
Merged

Add basic typechecking#72
MarcellPerger1 merged 126 commits into
mainfrom
add-typechecking

Conversation

@MarcellPerger1

@MarcellPerger1 MarcellPerger1 commented Jun 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Owner
  • Added basic typechecking
  • Resolve TODOs in code
  • Split into several modules
  • Add a few unittests
  • Add e2e test using example 2 (will require some modifications though)
  • Add fuzzing

For now the typechecking is very basic and proof-of-concept. We may need to create a typed AST.

@MarcellPerger1 MarcellPerger1 added T-feature A new feature A-TypeChecking Area: Type checking/name resolution labels Jun 15, 2025
@MarcellPerger1
feat(typecheck): Better type formatting in error messages
878bee3
@MarcellPerger1
refactor(cst): Remove unneeded cast
22a8a5b
@MarcellPerger1
refactor(ast): Replace code with Pycharm-friendly version
fa6dee3
@MarcellPerger1
refactor(cst): Improve type annotations a bit
188fa54
@MarcellPerger1
refactor(ast): Improve type alias placement?? Well, Pycharm likes it …
4263415 
…better anyway
@MarcellPerger1
refactor(ast): Generic-based AstNode metadata in preparation for addi…
4a95006 
…ng type info to nodes

(So I don't have to create yet another tree of node classes and another set of converters)
@MarcellPerger1
feat(typecheck): Add types to AST in a rather clean way
32db947 
TODO: AST types, return AST rather than True/False
@MarcellPerger1
refactor(types): Fix outdated type annotation
b545f05 
`__notes__` isn't present any more
@MarcellPerger1
feat(typecheck+types): Add proper types for typed AST
b26f9a5
@MarcellPerger1

MarcellPerger1 commented Apr 23, 2026

Copy link
Copy Markdown
Owner Author

Ok, so need to fix the snapshot-fmt to be same as before for the untyped AST.

@MarcellPerger1
refactor(cst): Remove no-longer-needed cast
6f2092b
@MarcellPerger1
ci: Don't fail-fast (we need to know if it fails on just old versions…
af0257c 
… or all versions)
@MarcellPerger1
ci: Add Python 3.13 and 3.14 to testing matrix
4505ce0 
TODO: should stop supporting 3.10 soon, by November at the latest
@MarcellPerger1
feat: Fix tree printing, massive refactor
5f20c19
@MarcellPerger1
test: Tests for tree printing
d51d535 
(Note: this and last commit were TDD'd together - well the TDD was used for bug fixes)
@MarcellPerger1
chore: Add note about broken recursive_eq function
cbb23c7
@MarcellPerger1
refactor: Split monolithic typecheck.py into multiple modules
5845f28
@MarcellPerger1
chore: Update fuzzing corpus
90341f6
@MarcellPerger1
feat(tree-print): Make removing defaults more general
aaa8b34
@MarcellPerger1
chore: Update fuzzing corpus
a9562ef
@MarcellPerger1
refactor: Move region display to str_region.py (rather than being in …
294b5e7 
…error.py)
@MarcellPerger1
test: Fix mocks that tried to replace old method
e026641
@MarcellPerger1
refactor(common+types): Improve types and docstring
c09ca48
@MarcellPerger1
test(cst): Add tests for previously-broken CST node parent attribute
90a5ad5
@MarcellPerger1
refactor(cst+types): Improved types named_node.py
adb4a46 
Still needs the big refactor though, see #84
@MarcellPerger1
refactor(util): Add pack_if_single_item util function
8467e15
@MarcellPerger1
test(typecheck): Add test for no-value let
3be6dd2
@MarcellPerger1
chore(typecheck): Remove old commented-out attribute
a30a955
@MarcellPerger1
refactor(name-resolve): Use stored global resolver in `ScopeNameResol…
dfa87b8 
…ver`
@MarcellPerger1
refactor(typecheck): Various minor improvements (extra sanity checks,…
afd9e55 
… clearer code)
@MarcellPerger1
ci(bench): Added typechecker to benchmark, proper benchmarks directory
ca05136
@MarcellPerger1
ci(dead-code): Updated vulture script
568829f
@MarcellPerger1
refactor(typecheck): Remove unused/unwritten attribute
6b67b4c
@MarcellPerger1
fix(ci): Fix fuzzing advanced-switch
f749d58
@MarcellPerger1
refactor(test): Remove duplicated code in tests
04eeb33
@MarcellPerger1
fix(test): Remove broken 'short-circuit' check
71ecb8b
@MarcellPerger1
style(test): Remove old comment from snapshottest.py
a0c5de8
@MarcellPerger1
style(test): Remove empty line
718562c
@MarcellPerger1
refactor(test+tprint): Simplify dedent function
847f304
@MarcellPerger1
refactor(test+fuzz): Reorganise fuzzing so tests don't require `pytho…
0b3e3b1 
…nfuzz`
@MarcellPerger1
style(test): Add comment about snapshot testing
d5754a9
@MarcellPerger1
refactor(test): Move BoundMock to test.common.utils, use that ins…
5fca29d 
…tead of `_PatchRegionDisplay`
@MarcellPerger1
fix(test): Rename BoundMock to MethodMock, make it actually work (was…
e062c90 
… very broken)
@MarcellPerger1
refactor(util+types): Improve types for typeof dataclass.MISSING
7d3d7be
@MarcellPerger1
fix(ci(fuzz)): Fix fuzz-type check
df23f6e
@MarcellPerger1
ci: Purge corpus
0f1edad
@MarcellPerger1

MarcellPerger1 commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner Author

Oops, it didn't find the corpus directory. That'll be fixed in next commit once I upload the new corpus from the 5M iteration run. (In a few hours, it is going at 1200 exec/s at the moment)

@MarcellPerger1
MarcellPerger1 merged commit 9f7ffcb into main Jul 23, 2026
5 checks passed
@MarcellPerger1
MarcellPerger1 deleted the add-typechecking branch July 23, 2026 16:00
@MarcellPerger1 MarcellPerger1 mentioned this pull request Aug 28, 2026
Closed
@MarcellPerger1 MarcellPerger1 linked an issue Aug 28, 2026 that may be closed by this pull request
Type checking #39
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-TypeChecking Area: Type checking/name resolution T-feature A new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Type checking

1 participant

@MarcellPerger1