Game crashes when loading the save

[DeadStranded]

Describe the bug
Whenever i use the editor v1.0.8 fix it crashes the game when is loading the save

To Reproduce
Steps to reproduce the behavior:

1. Just edit something and try to load the save on the game

Expected behavior
the save doesn't crash when loading on the game

[Marcel-TO]

Hello @DeadStranded,

in order to find a possible solution to your problem, I need to have more information.

Are you playing on PS or PC?
What did you change in particular? Skill or Inventory? Initial Value to what value?

[DeadStranded]

I play on PS, in seperate events i changed a legend skill, swapped a weapon, change rarity on a weapon, change stats on a weapon, swapped an accesorie and in all cases the save crashed the game when loading in the game

[Marcel-TO]

Let's focus on the skill values.

First make sure that the file is getting saved properly. In order to do this, load a save and save it without changing anything. Open the new file in a text and additionally hex editor and check if it looks similar to the original. (It should look like this: )

If confirmed, change the skill value and save the file. Open original and new in hex editor, go to the index/offset that is displayed by the editor and check if the 2 bytes after the id got changed correctly.

Last but not least, since it is a common struggle, make sure that all steps for encrypting are done as intended

[DeadStranded]

I just did this, all was as intended but found 2 problems:

1.- I tried to change the heal on damage skill that is 3rd in the second page of legend skills on the save editor and whenever i selected "save" on the pop up panel after writing the new value it changed the 3rd skill from the first page of legend skill wich was xbow damage.

2.- I stayed with the xbow skill, i changed the value from 30k to 10 (0A) and save the changes, i searched for that skill and it was changed to 0A but only the LP_xbow_dmg_skill not the LP_xbow_dmg, i imported the save and loaded it into the game, the game didn't crash but there was no changes on the skill in game. I opened the save on advanced mode on save wizard and the value still was 0A

[Marcel-TO]

@DeadStranded great investigation.

Regarding your 2nd issue, this is working as intended. The game itself does not directly change the value of the legend skills. But when looking through the stat details, you will see the percentages changing. This is what you want to check when changing legend skills.

And your first issue makes me very curious. If the Inventory items would have gotten switched, then this would not surprise me. The inventory structure splits id data (+ mods) and the chunk data (level, seeds, amount, dura). And sometimes, depending on which tab (for example weapons) is where the order of the items <-> chunk swapped.
But Skills shouldn't do this, since it there is no mapping involved. The editor gets the regex pattern and takes the last 2 values between ID and SGDs. This is the value of the Items: I attached an image that marks the position of the values.

Maybe send a screenshot of the Index displayed on the editor and what Skill gets pointed to.

[DeadStranded]

i checked the skill was still 30k, checked the stats and bow and xbow damage was 90k%, not sure if i'm doing something wrong

Here's a video of the issue with the editor while changing values on different pages
https://youtu.be/MSMzqFj1PlY?si=Vw0GYw2N1PuT5qTC

[Marcel-TO]

To clearify. If I understand the video correctly, when changing a value and switching between pages, the values of the items resets?
And you think that this causes the save to not change the skill values?

[DeadStranded]

No, if you have all legend skill unlocked you will have 2 pages on the save editor the first with 10 and the second with 6, on the video i tried to change the skill number 3 of the second page, when i selected "save" it applied the changes to the skill numer 3 of the first page instead.

When i tested what you told me i checked on hex editor the skill of the first page the one that the changes were applied to on the save editor and the value was changed as supposed but in game i wasn't changed at all.

They are 2 different issues, the first issue is on the save editor, the 2nd i may did something wrong idk, I'm going to try again later and i'll let you know

[Marcel-TO]

After digging through the code I found the culprit for the issue inside the editor. The index mapping uses, as you correctly suggested, the page index, not the overall index. This needs to get adjusted for future releases.

src/components/custom/data-table-component.tsx

<TableBody>
  {table.getRowModel().rows?.length ? (
    table.getRowModel().rows.map((row, index) => (
      <TableRow
        key={row.id}
        data-state={row.getIsSelected() && "selected"}
        onClick={() => {
          if (executeFunctionForRow) {
            executeFunctionForRow(row.original, index); // <- this takes the index of the current page. not the index through all pages
          }
        }}
      >
        {row.getVisibleCells().map((cell) => (
          <TableCell key={cell.id}>
            {flexRender(
              cell.column.columnDef.cell,
              cell.getContext()
            )}
          </TableCell>
        ))}
      </TableRow>
    ))
...

Appreciate you for bringing it to my attention and sticking with the conversation. Regarding the other problem, I would once again try changing a different legend skill and check stat %. Didn't receive any issues by my trusted testers, therefore my assumption that this still works. I do not have time the time to investigate it for the next few days. Lets see where this leads