Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Google Playstore Analytics app #27

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Added Google Playstore Analytics app #27

merged 1 commit into from
Feb 6, 2020

Conversation

lyqht
Copy link
Contributor

@lyqht lyqht commented Feb 6, 2020

Following the issue #26,

  • Why this app is awesome: I built this app in place of the standard ppt presentation of data science projects for a school project 😄 and encouraged the Prof to try out streamlit too.
  • Tests: I've ran invoke test.all and none has failed.
  • Any errors: However, I'm not able to run the full app to see the website due to the error No module named 'awesome_streamlit', tried compiling the package by python package/setup.py, the commands ran but it was still unable to find the package. Please assist!

@MarcSkovMadsen MarcSkovMadsen merged commit 8304dcb into MarcSkovMadsen:master Feb 6, 2020
@MarcSkovMadsen
Copy link
Owner

MarcSkovMadsen commented Feb 6, 2020

Hi @lyqht.

I've played a little bit around with it to understand what is going on. As your setup might be different than mine I don't know exactly what you should do to get it working. But here are some hints.

  • Make sure you run all commands from the root of the project. I.e. the folder where you find license.md.
  • Make sure you add nltk to requirements_local.txt. I've done this now.
  • Make sure you have run pip install -r requirements_local.txt
    • This should also install the awesome_streamlit package.
    • An alternative is to only install the awesome_streamlit package using pip install -e ./package.
  • The way awesome-streamlit (currently) works requires
    • Your code should be in one .py file. So merge everything in to main.py
    • Your paths should be urls. The assets and data is now available on Github (see below).

image

Hope this helps. Otherwise let me know.

@MarcSkovMadsen
Copy link
Owner

MarcSkovMadsen commented Feb 6, 2020

And this is how far I can get right now.

image

An alternative to providing urls is to assume everything is run from the root folder and change the above path to gallery/googleplaystore_analytics/assets/logo.png. And all other paths similarly.

@lyqht
Copy link
Contributor Author

lyqht commented Feb 6, 2020

ohh okay, ill fix the paths and merge all the files into one.

but since it wasn't working, maybe it shouldnt have been merged in yet xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants