writer.py: postpone creating the output file #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows can't unlink a file while it is still open, and raises an exception. Additionally, self.output_file isn't accessed anywhere else, by any methods. As such, creation should happen *after* we make sure that there are no bugs.
|
The motivation for creating a file early is to fail fast if the file can't be created (e.g. parent directory doesn't exist or insufficient access rights). |
|
Right, do you foresee a problem with closing the file early, in the exception branch? That was basically the other quick fix I considered. |
|
Closing + unlinking? Or just closing? |
|
Closing the file before we attempt to unlink it -- if there is an error. Code talks better than descriptions, so I guess later today I'll just revert this, make that tiny change, and you can take it from there. No point in spending more time than that, when the fix I have in mind is literally on the order of four lines. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows can't unlink a file while it is still open, and raises an exception.
Additionally, self.output_file isn't accessed anywhere else, by any methods.
As such, creation should happen after we make sure that there are no bugs.